fix(text/unstable): only strip single trailing newline in dedent #6913
+16
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes denoland#6831 The dedent function was using `.trimEnd()` which removes ALL trailing whitespace including multiple newlines. This is inconsistent with npm:string-dedent which only removes a single trailing newline. Changes: - Replace `.trimEnd()` with `.replace(/\n[\t ]*$/, "")` to only strip a single trailing newline (with any preceding whitespace on that line) - Updated documentation to reflect the new behavior Before: ```ts dedent\` a \` // returns 'a' (all trailing newlines stripped) ``` After: ```ts dedent\` a \` // returns 'a\n' (only one trailing newline stripped) ```
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6913 +/- ##
==========================================
+ Coverage 94.14% 94.16% +0.01%
==========================================
Files 583 583
Lines 42806 42813 +7
Branches 6815 6815
==========================================
+ Hits 40301 40316 +15
+ Misses 2455 2446 -9
- Partials 50 51 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kt3k
reviewed
Dec 26, 2025
text/unstable_dedent_test.ts
Outdated
| const result = dedent` | ||
| a | ||
| `; | ||
| assertEquals(result, "a"); |
Member
There was a problem hiding this comment.
This case seems already passing with the existing code i.e. it doesn't seem testing what this PR changes. I'm removing this case
kt3k
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #6831
The
dedentfunction was using.trimEnd()which removes ALL trailing whitespace including multiple newlines. This is inconsistent withnpm:string-dedentwhich only removes a single trailing newline.Changes
.trimEnd()with.replace(/\n[\t ]*$/, "")to only strip a single trailing newline (with any preceding whitespace on that line)Before
After
Testing
The fix ensures consistency with
npm:string-dedent@3.0.2behavior.